Skip to content

gh-96702: Order methods before attrs in sqlite3.Connection docs - #96703

Merged
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:sqlite-docs/connection-order
Sep 13, 2022
Merged

gh-96702: Order methods before attrs in sqlite3.Connection docs#96703
erlend-aasland merged 2 commits into
python:mainfrom
erlend-aasland:sqlite-docs/connection-order

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Sep 9, 2022
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 9, 2022
@erlend-aasland erlend-aasland linked an issue Sep 9, 2022 that may be closed by this pull request

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay—LGTM, thanks @erlend-aasland . One minor non-blocking comment.

Comment thread Doc/library/sqlite3.rst Outdated
@erlend-aasland
erlend-aasland merged commit 49cceeb into python:main Sep 13, 2022
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland
erlend-aasland deleted the sqlite-docs/connection-order branch September 13, 2022 08:29
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 49cceeb5c998a51bb12b7dbde17b53647bb52113 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2022
…pythonGH-96703)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 13, 2022
@bedevere-bot

Copy link
Copy Markdown

GH-96788 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Sep 13, 2022
…on docs (pythonGH-96703).

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Sep 13, 2022
@bedevere-bot

Copy link
Copy Markdown

GH-96789 is a backport of this pull request to the 3.10 branch.

erlend-aasland added a commit that referenced this pull request Sep 13, 2022
GH-96703). (#96789)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Sep 14, 2022
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
…6703) (#96788)

(cherry picked from commit 49cceeb)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlite3 docs: Connection methods and attribute order

4 participants